Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461776 Orcan Ogetbil <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #1 from Orcan Ogetbil <[EMAIL PROTECTED]> 2008-10-05 04:27:42 EDT --- The package is (almost) perfect. Koji build is good too. http://koji.fedoraproject.org/koji/taskinfo?taskID=861703 Here are my notes: ------------------------------------------------------------------------- You include a .desktop file in the package. Shouldn't you call some update-database script to let KDE know that you added something? I'm just asking (not requiring). ------------------------------------------------------------------------- According to http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags packages should honor Fedora-specific compiler flags. Make sure that $RPM_OPT_FLAGS is being honored and used. ------------------------------------------------------------------------- This is one of my favorite plasma applets. IMHO It should be included in KDE. Thanks for packaging. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
