Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=446847 Rakesh Pandit <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Rakesh Pandit <[EMAIL PROTECTED]> 2008-10-07 00:04:30 EDT --- APPROVED Suggestions: 1. Fix space and tab mix 2. Include CHANGES also NA = Not applicable, ! = requires attention, x = passed http://koji.fedoraproject.org/koji/taskinfo?taskID=865791 [EMAIL PROTECTED] SRPMS]$ rpmlint nagios-plugins-check_sip-1.2-4.fc9.src.rpm nagios-plugins-check_sip.src: W: mixed-use-of-spaces-and-tabs (spaces: line 57, tab: line 3) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Please correct this [EMAIL PROTECTED] i386]$ rpmlint -i nagios-plugins-check_sip-1.2-4.fc9.i386.rpm nagios-plugins-check_sip.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. Fine nagios-plugins-check_sip.i386: E: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Fine 1 packages and 0 specfiles checked; 2 errors, 0 warnings. Required: [x] package name [x] package base name and spec name [x] packaging guidelines [x] license file included [x] license correct [x] spec legible & in American english [x] md5sum checked source okay [x] package compiled on all primary architectures [x] Buildrequires tag - okay [NA] locale [NA] desktop file - GUI [x] owns all directories it creates [x] permissions in %defattr correct [x] %clean and %install section have 'rm -rf $RPM_BUILD_ROOT' [x] %doc files don't have any dependency on other section of package [x] valid encoding Optional: [x] description and summary fine [NA] license file query [x] package functioning - okay [x] any scripts [x] no dependencies outside FHS guideline paths [!] you may like to include CHANGES file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
