Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465851


Jon Ciesla <[EMAIL PROTECTED]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[EMAIL PROTECTED]    |[EMAIL PROTECTED]
               Flag|                            |fedora-review?




--- Comment #4 from Jon Ciesla <[EMAIL PROTECTED]>  2008-10-14 09:21:02 EDT ---
rpmlint is clean all around.

License tag should be GPLv3+.

Please comment on patch status WRT upstream, and submit upstream if necessary.

Would this benefit from a .desktop file and icon?  You would either have it run
against the example.  You could have it run against /var/log/httpd/access_log,
but that'd need root and require httpd.  Something to consider.

Otherwise, full review is good, no BuildRequires missing.

And I'll have a peek at 254059.  If you wanted to reciprocate, 452107 should be
pretty straightforward.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to