Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467293 Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] Blocks| |182235 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> 2008-10-17 00:59:56 EDT --- * The description needs to be descriptive. * Won't you need Requires: scummvm = %version instead of Requires: scummvm >= 0.12.0 * License should be GPLv2+ as told by the source files. * In the .desktop file - put a "Generic Name:" with a very brief description. - also it would be more comlpliant with the existing ScummVM package if you make the "Name: ScummVM Tools". - afaik you shouldn't have Application as a category in a .desktop file. * Compiler flags need to be appropriate. This is C++ code, so in order to honor Fedora specific compilation flags you will most likely need to play with the CXXFLAGS. Make sure they are not overridden by the other CXXFLAGS in the Makefile. You shouldn't set CFLAGS as it is irrelevant for this package. * Did you submit the patch upstream? * As far as I understood, this application is primarily used to extract information from non-free software, although most of which are now abandonware. I am not sure if this is OK to release in Fedora. I am blocking FE-Legal . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
