Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=467627 --- Comment #2 from David Kaylor <[EMAIL PROTECTED]> 2008-10-20 22:11:38 EDT --- This packages is in good shape. After checking against the guidelines and doing another compile with mock, I found just a couple of minor things: Exiting with 0 at the end of the %pre script is preferable to failing (http://fedoraproject.org/wiki/Packaging/UsersAndGroups). Patches should have a link to an upstream bug or a comment (http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
