Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462835 Fabian Affolter <[EMAIL PROTECTED]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[EMAIL PROTECTED] --- Comment #5 from Fabian Affolter <[EMAIL PROTECTED]> 2008-10-24 04:11:56 EDT --- Just some small comments on your spec file. release: 1 - add %{?dist} -> Release: 1%{?dist} license: GPL or Artistic - Should be License: GPL+ or Artistic https://fedoraproject.org/wiki/Packaging/Perl#License_tag buildrequires: perl(ExtUtils::MakeMaker) - Should be Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires source: Math-Calc-Units-1.06.tar.gz - The source should come from upstream. Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz https://fedoraproject.org/wiki/Packaging/SourceURL %changelog - add some thning like * Fri Sep 19 2008 <[EMAIL PROTECTED]> - 1.06-1 https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs For more details about packaging perl stuff please check https://fedoraproject.org/wiki/Packaging/Perl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
