Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476776


Jesse Keating <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?([email protected]
                   |                            |m)




--- Comment #2 from Jesse Keating <[email protected]>  2008-12-17 17:43:55 
EDT ---
- Patch should have a comment, and info about upstream status
- Mixed use of $RPM_BUILD_ROOT and %{buildroot}
- Builds OK in mock
- rpmlint output:
python-shove.noarch: W: summary-ended-with-dot Common object storage frontend.
python-shove.noarch: E: description-line-too-long Common object storage
frontend that supports dictionary-style access, object serialization and
compression, and multiple storage and caching backends.
python-shove.noarch: W: non-standard-group Development/Library


- upstream source matches
- All things in store/tests/ are unlicensed.

-- Summary --
Fix up the rpmlint stuff
ask upstream about license on tests/
Fix macro usage to be consistant
Add comment on the patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to