Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226166 --- Comment #12 from Dan Horák <[email protected]> 2008-12-22 15:07:48 EDT --- (In reply to comment #11) > Just more comments: > > * export CFLAGS="$RPM_OPT_FLAGS" should not be needed. > Please check what %configure actually does by > $ rpm --eval %configure the "export" line will be removed in next release > > * Please avoid to use %makeinstall unless impossible > > https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used the hand-written Makefiles doesn't support DESTDIR, so use of %makeinstall is needed, patch to correct the situation has been already submitted upstream -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
