Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=475055


Mamoru Tasaka <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[email protected]    |[email protected]
               Flag|                            |fedora-review?




--- Comment #3 from Mamoru Tasaka <[email protected]>  2008-12-26 
12:16:13 EDT ---
Some notes:

* License
  - The license tag should be "GPL+" as no version is specified
  - However LICENSE (and also README) file also says that files 
    under doc/ are non-free.
    Please follow
   
https://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code
    and remove all files under doc/ from the source tarball
    completely.
  - Include LICENSE file as %doc as this is important.

* CFLAGS
  - I guess
-------------------------------------------------------------
export CFLAGS="%{optflags}"
export CXXFLAGS="%{optflags}"
-------------------------------------------------------------
    is not needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
[email protected]
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to