Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=472794 D Haley <my...@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |my...@yahoo.com --- Comment #2 from D Haley <my...@yahoo.com> 2008-12-28 08:04:02 EDT --- Please excuse any really dumb questions, I am somewhat new at this process myself. Not a formal review: >$RPM_BUILD_ROOT Is there a preference for %{buildroot} for newer packages? ># This was obtained on 2008/11/24 using the following commands: ># cvs -d >:pserver:anonym...@onemind-commons.cvs.sourceforge.net:/cvsroot/onemind-commons > login ># cvs -d >:pserver:anonym...@onemind-commons.cvs.sourceforge.net:/cvsroot/onemind-commons > co commons-java/docs >Source1: %{name}-docs-20081124.tbz Can you check out a particular CVS version, rather than HEAD -- that way the md5sum can be verified as being consistent during review. I know the upstream is dormant, so this is probably a bit picky. >BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) I am unclear -- what is the reason for changing the BuildRoot? ("Fix BuildRoot to follow the latest guidelines") Can you point to a page (in your reply) for the less up-to-date of us? >%description >This is a common library used to support other onemind libraries. Is it possible to expand on this at all? Its identical to the summary -- doesn't really provide extra information to users. That said, I am not sure what one would write here as an alternative. >%{_javadir}/*.jar I think I would prefer %{name}.jar and {name}-%{version}.jar to be explicit. This prevents any later inadvertant jar copying (another picky comment.) Other than that, it seems OK to me. There are no jars, licence seems OK and GPL header present in all java files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
