Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=471754 --- Comment #7 from Dwayne Bailey <[email protected]> 2008-12-28 14:10:43 EDT --- (In reply to comment #6) > [FAIL]specfile is properly named, is cleanly written and uses macros > consistently. > The spec file should not have the version or at least not the revision number > as part of its name, it should be virtaal.spec The name of the .spec file at the download link is just for tracking purposes, my local copy is named virtaal.spec. > [FAIL]BuildRequires are proper. > > You should not have desktop-file-utils see: > http://fedoraproject.org/wiki/NewMIMESystem Fixed > [FAIL]rpmlint is silent. > > rpmlint virtaal-0.2-2.spec ../SRPMS/virtaal-0.2-2.fc10.src.rpm > ../RPMS/noarch/virtaal-0.2-2.fc10.noarch.rpm > virtaal.src: E: invalid-spec-name > > Rename Spec file See comment above > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/recent.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/about.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/__init__.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/widgets/label_expander.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/markup.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/document.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/formats.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/simplegeneric.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/tips.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/undo_buffer.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/unit_editor.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/store_grid.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/search_mode.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/unit_renderer.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/bijection.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/__init__.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/widgets/__init__.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/partial.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/openmailto.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/autocorrector.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/unit_layout.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/terminology.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/memoize.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/main_window.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/sorted_set.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/widgets/entry_dialog.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/pan_app.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/mode_selector.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/widgets/util.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/autocompletor.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/store_model.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/modes.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/support/set_enumerator.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/__version__.py 0644 > virtaal.noarch: E: non-executable-script > /usr/lib/python2.5/site-packages/virtaal/rendering.py 0644 > 2 packages and 1 specfiles checked; 36 errors, 0 warnings. Should I fix these? These shouldn't be executable but they all have #! headers. > [?]desktop files valid and installed properly. > The version in the desktop file is 1.0 but 0.2 for the package is that > correct? This is correct, it refers to the standard version, not the application version number, See: http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html > There are a few things that need to be fixed before I will sign this package > off. Thanks for the review. The only outstanding issue is the 'non-executable script' error, your feedback on that would be appreciated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
