Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478534 Fabian Affolter <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Fabian Affolter <[email protected]> 2009-01-01 05:09:26 EDT --- Just some quick comment on your spec file - It would be nice if you are not using a macro in URL because copy-and-paste is not possible from the spec file for humans - Your missed to verify/install the desktop file. https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files - With make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" you can preserve the time stamps - I think 'BR: GConf2-devel' is not needed BTW, happy new year. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
