Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=477750 --- Comment #3 from Matthias Saou <[email protected]> 2009-01-02 14:10:11 EDT --- Initial comment about the licensing (formal review pending) : The Licensing wiki page states that "A GPL or LGPL licensed package that lacks any statement of what version that it's licensed under in the source code/program output/accompanying docs is technically licensed under *any* version of the GPL or LGPL, not just the version in whatever COPYING file they include.", so since here the sources contain only "Distributed under the GPL", the License: field should be "GPL+" and not "GPLv2". Note that lots of files state "Based on Xiph.org's 'oggmerge' found in their CVS repository", but that doesn't seem to be a problem, as it has exactly the same plain "Distributed under the GPL" statement. See : https://trac.xiph.org/browser/trunk/ogg-tools/oggmerge/oggmerge.c All of the rest does look fine. Just that ChangeLog which could be converted to UTF-8, though I wouldn't consider that a blocker (I would if it was the main README for instance). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list [email protected] http://www.redhat.com/mailman/listinfo/fedora-package-review
