Upayavira wrote:
It is great to see you working hard on this. I get the impression that this was quite a knotty one.
Actually, the implementation turned out to be pretty straightforward...the difficulty was more just deciding on the approach. This work has taken me a while because I have been working on presentations and papers and have been traveling a lot (currently in Taiwan), so I have been basically stealing time to work on the URL Handlers implementation. :-)
I'd like, however, to ask if it is at all possible for you to do this kind of development work in a more bite-sized way. If your code comes in in small increments, you'll find that the community will likely understand it better, and thus be better equipped to help maintain/enhance it. Otherwise, it could just end up with us all deferring to you for maintenance of this code, which wouldn't be ideal. If you're concerned about breaking something, you can always commit the code you've done so far to some sandbox in SVN, then use svn move to move it to the correct resting place once it works. Consider this approach as a training exercise for the rest of us! Does this sound reasonable/plausible?
Sounds reasonable to me. However, in this particular situation I really cannot do this because I actually started this work on my Oscar 1.0.5 code base, so it is not something I can commit until I forward port it to Felix. I started working on a 1.0.6 version of Oscar a while back because I realized I broke the old URL Handlers service when I implemented getResources() in Oscar 1.0.5. Oops! :-)
Luckily, these changes are fairly self-contained, so it should be easy to forward port and hopefully easy to understand.
-> richard