Why is it improper to use an inner class for the AdminPermissionCollection?

Well it could be an non-member inner class (i.e. "static class"). But to
be an member inner class means it holds an implicit reference to a single
AdminPermission object which is wrong for a PermissionCollection.

Good point. I applied your patch in regard to the AdminPermissionCollection.
See revision 437838.

However, I need a bit more time to get to that point (and to find a
good place too).

Sure. As long as the public signature of the OSGi classes are unaltered
when you are all finished.

Definitely, I'll comment on the JIRA asap. In truth, there are more
issues that I need to get fixed first (BundleSignerCondition will need
it to be moved anyways, but there are some more problems with making
it none public right now). Hopefully, I get there shortly.

BJ Hargrave
Senior Technical Staff Member, IBM
OSGi Fellow and CTO of the OSGi Alliance
[EMAIL PROTECTED]
Office: +1 407 849 9117 Mobile: +1 386 848 3788

regards,

Karl

--
Karl Pauls
[EMAIL PROTECTED]

Reply via email to