Yes. I'm also no expert in regexp but with what I know the added + indicates that there should be at least 1 digit. Works also in practice since I built all the commons using mine modified maven-bundle-plugin
Alin Dreghiciu On 3/15/07, Richard S. Hall <[EMAIL PROTECTED]> wrote:
Alin Dreghiciu (JIRA) wrote: > maven-bundle-plugin, versions with more then 1 digit, and - before qualifier > ---------------------------------------------------------------------------- > > Key: FELIX-256 > URL: https://issues.apache.org/jira/browse/FELIX-256 > Project: Felix > Issue Type: Bug > Components: Maven Plugin > Reporter: Alin Dreghiciu > > > maven-bundle-plugin will replace the first - from the version of the artifact with an . in order to form an osgi valid version. The problem is that the regexp used to figure if it should replace it does not match if there are two digits in the second/third group from the version. So a version as 1.2.8-SNAPSHOT will match and be transformed to 1.2.8.SNAPSHOTbut 1.2.12-SNAPSHOT will not match and result in an invalid osgi version that will be correctrly chached by bnd. > So > Pattern P_VERSION = Pattern.compile("([0-9]+(\\.[0-9])*)-(.*)"); > should become > Pattern P_VERSION = Pattern.compile("([0-9]+(\\.[0-9]+)*)-(.*)"); > > This is also the problem from FELIX-230. > > Pleae solve asap since is an easy fix and will speedup felix Just to verify, are you saying we just need to apply the above change to fix it? If so, I can do it... I don't really know the regex API and didn't create this code in the first place... -> richard
