B1;3400;0cOn Sun, May 19, 2013 at 07:12:53PM +0100, Garth N. Wells wrote: > The file ale.py has a bunch a free functions 'compute_vertex_map', > 'compute_edge_map', etc. Why are they there? The names a rather > meaningless as free functions, and the computation would be much > better done of the C++ side.
They were added at some point as utility functions for extracting the connection between different meshes for FSI and are used in CBC.Solve. I don't think they are very mysterious but agree they should really be renamed and implemented in C++, if they at all belong in DOLFIN. Could a temporary solution be to rename the functions to ale_compute_vertex_map ale_compute_edge_map ? I'm not sure how actively maintained CBC.Solve is going to be in the future, so if we rename the functions for now, we can decide whether to remove them later when the situation has clarified. Either CBC.Solve will be actively maintained (by myself or someone else) and then the functions can be moved elsewhere or reimplemented in C++. If not, the functions can be removed. -- Anders > The reason I'm looking at these functions is part of resolving the > circular dependency problem with MeshData holding MeshFunctions. > > Garth > _______________________________________________ > fenics mailing list > [email protected] > http://fenicsproject.org/mailman/listinfo/fenics _______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
