On Tue, Nov 19, 2013 at 02:46:44PM +0000, Garth N. Wells wrote: > On 2013-11-19 14:37, Johan Hake wrote: > >Well... > > > > From a clean install it should work but with git pull updates the > >logic does not always kick in... > > > > It is a make target so you can also: > > > > make generate_swig_interface > > > >in the build directory. > > > > When in doubt, . . . . > > git clean -fdx
Now added to the cookbook: https://bitbucket.org/fenics-project/dolfin/wiki/Git%20cookbook%20for%20FEniCS%20developers -- Anders > Garth > > >Johan > > > >On Tue, Nov 19, 2013 at 3:09 PM, Jan Blechta > ><[email protected]> wrote: > > > >>On Tue, 19 Nov 2013 14:54:47 +0100 > >>Jan Blechta <[email protected]> wrote: > >> > >>>On Tue, 19 Nov 2013 12:10:16 +0000 > >>>"Garth N. Wells" <[email protected]> wrote: > >>> > >>>> On 2013-11-19 11:38, Jan Blechta wrote: > >>>> > Hi Garth, > >>>> > > >>>> > would you check line 56 in mesh/MeshQuality.cpp: > >>>> > > >>>> > 44 std::pair<double, double> > >>>> > MeshQuality::radius_ratio_min_max(const Mesh& mesh) > >>>> > 45 { > >>>> > 46 CellIterator cell(mesh); > >>>> > 47 double qmin = cell->radius_ratio(); > >>>> > 48 double qmax = cell->radius_ratio(); > >>>> > 49 for (; !cell.end(); ++cell) > >>>> > 50 { > >>>> > 51 qmin = std::min(qmin, cell->radius_ratio()); > >>>> > 52 qmax = std::max(qmax, cell->radius_ratio()); > >>>> > 53 } > >>>> > 54 > >>>> > 55 qmin = MPI::min(qmin); > >>>> > 56 qmax = MPI::min(qmax); > >>>> > 57 return std::make_pair(qmin, qmax); > >>>> > 58 } > >>>> > > >>>> > This seems like a typo. > >>>> > > >>>> > >>>> Thanks Jan. I've pushed a fix. > >>>> > >>>> > Is there a demo or a piece of code showing how to use > >>>> > MeshQuality::radius_ratio_matplolib_histogram ? > >>>> > > >>>> > >>>> Take a look at the function > >>>> > >>>> test_radius_ratio_matplotlib(self): > >>>> > >>>> in > >>>> > >>>> test/unit/mesh/python/MeshQuality.py > >>> > >>>My pyDOLFIN does not have MeshQuality class. This must be problem > >>on > >>>my side if tests pass on buildbots. Should I manually regenerate > >>SWIG > >>>interface somehow? > >> > >>Ah sorry, this required just running > >>cmake/scripts/generate-swig-interface. I thought that this is now > >>handled by cmake. > >> > >>Jan > >> > >>> > >>>Jan > >>> > >>>> > >>>> Garth > >>>> > >>>> > Jan > >>> > >>>_______________________________________________ > >>>fenics mailing list > >>>[email protected] > >>>http://fenicsproject.org/mailman/listinfo/fenics [1] > >> > >>_______________________________________________ > >>fenics mailing list > >>[email protected] > >>http://fenicsproject.org/mailman/listinfo/fenics [1] > > > > > > > >Links: > >------ > >[1] http://fenicsproject.org/mailman/listinfo/fenics > > > >_______________________________________________ > >fenics mailing list > >[email protected] > >http://fenicsproject.org/mailman/listinfo/fenics > _______________________________________________ > fenics mailing list > [email protected] > http://fenicsproject.org/mailman/listinfo/fenics _______________________________________________ fenics mailing list [email protected] http://fenicsproject.org/mailman/listinfo/fenics
