On Mon, Aug 25, 2014 at 06:35:11AM +0200, Reimar Döffinger wrote: > On 24.08.2014, at 20:39, [email protected] (Michael Niedermayer) wrote: > > - if ((tag = av_dict_get(st->metadata, "alpha_mode", NULL, 0)) || > > - (tag = av_dict_get( s->metadata, "alpha_mode", NULL, 0)) || > > + if (((tag = av_dict_get(st->metadata, "alpha_mode", NULL, 0)) && > > atoi(tag->value)) || > > + ((tag = av_dict_get( s->metadata, "alpha_mode", NULL, 0)) && > > atoi(tag->value)) || > > Not sure it matters, but wouldn't value == NULL have worked before but would > crash now?
iam not sure i understand tag->value should never be NULL av_dict_set with a NULL value would delete the entry [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-cvslog mailing list [email protected] http://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
