This is an automated email from the git hooks/post-receive script.

Git pushed a commit to branch release/4.4
in repository ffmpeg.

commit 247ad1199feaae68c0224cace9407ef1a940f85b
Author:     Andreas Rheinhardt <[email protected]>
AuthorDate: Fri Feb 23 18:54:10 2024 +0100
Commit:     Michael Niedermayer <[email protected]>
CommitDate: Sun Jun 21 17:59:33 2026 +0200

    configure: Disable linker warnings for common symbols
    
    Common symbols are not part of ISO-C and therefore not used
    by FFmpeg at all. Yet linker warnings to ensure it stays
    that way are nevertheless wrong, because the existence of
    common symbols does not imply that there is a bug in our code.
    
    More precisely, Clang's ASAN implementation uses a common symbol
    ___asan_globals_registered when used on Elf targets with
    the -fsanitize-address-globals-dead-stripping option;
    said option is the default since Clang 17 [1].
    This leads to 1883 warnings about ___asan_globals_registered
    when linking here.
    (Even without that option there were warnings like
    _ZN14__interception10real_vforkE being overridden.)
    
    Said warning is also unnecessary: The proper way to ensure
    that our code is free of common symbols is to let the compiler
    enforce this. But this is already the default since GCC 10
    and Clang 11, so there is no risk of introducing our own
    common symbols.
    
    [1]: https://reviews.llvm.org/D152604
    
    Signed-off-by: Andreas Rheinhardt <[email protected]>
    (cherry picked from commit 25e0e087c4314730d42ac16061962904b8fb3ae6)
    Signed-off-by: Michael Niedermayer <[email protected]>
---
 configure | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure b/configure
index e5bd6bc8cf..ae4e5e2dbf 100755
--- a/configure
+++ b/configure
@@ -6873,7 +6873,6 @@ void (^block)(void);
 EOF
 
 # add some linker flags
-check_ldflags -Wl,--warn-common
 check_ldflags 
-Wl,-rpath-link=:libpostproc:libswresample:libswscale:libavfilter:libavdevice:libavformat:libavcodec:libavutil:libavresample
 enabled rpath && add_ldexeflags -Wl,-rpath,$libdir && add_ldsoflags 
-Wl,-rpath,$libdir
 test_ldflags -Wl,-Bsymbolic && append SHFLAGS -Wl,-Bsymbolic

_______________________________________________
ffmpeg-cvslog mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to