This is an automated email from the git hooks/post-receive script.
Git pushed a commit to branch master
in repository ffmpeg.
The following commit(s) were added to refs/heads/master by this push:
new a693a4cd80 tests/fate/generic-tags: use codec copy instead of encoding
a693a4cd80 is described below
commit a693a4cd802d33d9994761a8c7c8b69d9f913d17
Author: James Almer <[email protected]>
AuthorDate: Wed Jul 1 14:17:20 2026 -0300
Commit: James Almer <[email protected]>
CommitDate: Wed Jul 1 14:35:14 2026 -0300
tests/fate/generic-tags: use codec copy instead of encoding
Using ac3_fixed output was not enough as there's float to int conversion
due to
the fact the mp3float decoder is used.
Instead of playing with codec combinations, just remove encoding from the
test
altogheter. Mov supports muxing mp3 just fine.
Signed-off-by: James Almer <[email protected]>
---
tests/fate/generic-tags.mak | 4 +-
tests/ref/fate/generic-tags-remux-mov | 77 ++++++++++++++++++++---------------
2 files changed, 46 insertions(+), 35 deletions(-)
diff --git a/tests/fate/generic-tags.mak b/tests/fate/generic-tags.mak
index 62ef2308b0..635c895e4b 100644
--- a/tests/fate/generic-tags.mak
+++ b/tests/fate/generic-tags.mak
@@ -23,9 +23,9 @@ FATE_GENERIC_TAGS-$(call REMUX, MP3, WAV_MUXER WAV_DEMUXER
PCM_S16LE_ENCODER PCM
fate-generic-tags-remux-riff: tests/data/generic-tags.mp3
fate-generic-tags-remux-riff: CMD = generic_tags mp3
$(TARGET_PATH)/tests/data/generic-tags.mp3 wav pcm_s16le "-t 0 -af aresample"
-FATE_GENERIC_TAGS-$(call REMUX, MP3, MOV_MUXER MOV_DEMUXER AC3_FIXED_ENCODER
AC3_DECODER ARESAMPLE_FILTER) += fate-generic-tags-remux-mov
+FATE_GENERIC_TAGS-$(call REMUX, MP3, MOV_MUXER MOV_DEMUXER MPEGAUDIO_PARSER)
+= fate-generic-tags-remux-mov
fate-generic-tags-remux-mov: tests/data/generic-tags.mp3
-fate-generic-tags-remux-mov: CMD = generic_tags mp3
$(TARGET_PATH)/tests/data/generic-tags.mp3 mp4 ac3_fixed "-af aresample"
+fate-generic-tags-remux-mov: CMD = generic_tags mp3
$(TARGET_PATH)/tests/data/generic-tags.mp3 mp4 copy
FATE_SAMPLES_FFMPEG_FFPROBE += $(FATE_GENERIC_TAGS-yes)
fate-generic-tags: $(FATE_GENERIC_TAGS-yes)
diff --git a/tests/ref/fate/generic-tags-remux-mov
b/tests/ref/fate/generic-tags-remux-mov
index 3c613930e0..25bc866092 100644
--- a/tests/ref/fate/generic-tags-remux-mov
+++ b/tests/ref/fate/generic-tags-remux-mov
@@ -1,43 +1,54 @@
-6500c92bb8147ca1eb14ef41fbc4c220 *tests/data/fate/generic-tags-remux-mov.mp4
-13392 tests/data/fate/generic-tags-remux-mov.mp4
+f6544f83b6b59a90f6aa2b50c04b5776 *tests/data/fate/generic-tags-remux-mov.mp4
+18063 tests/data/fate/generic-tags-remux-mov.mp4
#tb 0: 1/44100
#media_type 0: audio
-#codec_id 0: ac3
+#codec_id 0: mp3
#sample_rate 0: 44100
#channel_layout_name 0: mono
-0, -256, -256, 1536, 416, 0x4e08b907, S=1, Skip Samples,
10, 0x00090001
-0, 1280, 1280, 1536, 418, 0xe2bdb9cb
-0, 2816, 2816, 1536, 418, 0x3a97c7c4
-0, 4352, 4352, 1536, 418, 0x2775c40f
-0, 5888, 5888, 1536, 418, 0xd12ac751
-0, 7424, 7424, 1536, 418, 0xd97ac051
-0, 8960, 8960, 1536, 418, 0x60f9bb7e
-0, 10496, 10496, 1536, 418, 0x418dc89b
-0, 12032, 12032, 1536, 418, 0xa905c386
-0, 13568, 13568, 1536, 418, 0x6ab3c0e0
-0, 15104, 15104, 1536, 418, 0x8c47c129
-0, 16640, 16640, 1536, 418, 0x1f5ec5c9
-0, 18176, 18176, 1536, 418, 0xc8decb76
-0, 19712, 19712, 1536, 418, 0xd7fdc93a
-0, 21248, 21248, 1536, 418, 0xf1bbc7ca
-0, 22784, 22784, 1536, 418, 0x5d4bcd8d
-0, 24320, 24320, 1536, 418, 0xd188c852
-0, 25856, 25856, 1536, 418, 0xc6ecc548
-0, 27392, 27392, 1536, 418, 0x5ca3cffb
-0, 28928, 28928, 1536, 418, 0x9684bfed
-0, 30464, 30464, 1536, 418, 0x9ec6ccfe
-0, 32000, 32000, 1536, 418, 0x73a2c4cd
-0, 33536, 33536, 1536, 418, 0x1738cc20
-0, 35072, 35072, 1536, 418, 0x46bac7b8
-0, 36608, 36608, 1536, 418, 0x5fe2b4ed
-0, 38144, 38144, 1536, 418, 0x92c1c2fb
-0, 39680, 39680, 1536, 418, 0xd01fc8b3
-0, 41216, 41216, 1536, 418, 0x1f1fcd05
-0, 42752, 42752, 1536, 418, 0xa35ecbab, S=1, Skip Samples,
10, 0x046800bc
+0, -1105, -1105, 1152, 417, 0xaea2b620, S=1, Skip Samples,
10, 0x034e0055
+0, 47, 47, 1152, 418, 0x04edc6dd
+0, 1199, 1199, 1152, 418, 0x2f1ac32b
+0, 2351, 2351, 1152, 418, 0xa5ebce7b
+0, 3503, 3503, 1152, 418, 0xa4e1d8b5
+0, 4655, 4655, 1152, 418, 0xf927d670
+0, 5807, 5807, 1152, 418, 0x4e8ccae5
+0, 6959, 6959, 1152, 418, 0x2b0ad5c2
+0, 8111, 8111, 1152, 418, 0x4a2fcc63
+0, 9263, 9263, 1152, 418, 0xe945dbc7
+0, 10415, 10415, 1152, 418, 0x601cd144
+0, 11567, 11567, 1152, 418, 0x052dc6a9
+0, 12719, 12719, 1152, 418, 0x348bd06b
+0, 13871, 13871, 1152, 418, 0x2996d2bd
+0, 15023, 15023, 1152, 418, 0xf658cc71
+0, 16175, 16175, 1152, 418, 0xeb19d2bf
+0, 17327, 17327, 1152, 418, 0xd547d84e
+0, 18479, 18479, 1152, 418, 0x4a59d73f
+0, 19631, 19631, 1152, 418, 0xedbcd9bf
+0, 20783, 20783, 1152, 418, 0x36c1d5fb
+0, 21935, 21935, 1152, 418, 0x30ddcf11
+0, 23087, 23087, 1152, 418, 0xc1c6d2de
+0, 24239, 24239, 1152, 418, 0xeed0cfc8
+0, 25391, 25391, 1152, 418, 0xe7bfde05
+0, 26543, 26543, 1152, 418, 0x3bbec91f
+0, 27695, 27695, 1152, 417, 0x82e1cc86
+0, 28847, 28847, 1152, 418, 0x9819cdd2
+0, 29999, 29999, 1152, 418, 0x2cddd971
+0, 31151, 31151, 1152, 418, 0x2b84d6f8
+0, 32303, 32303, 1152, 418, 0xe483ce32
+0, 33455, 33455, 1152, 418, 0x68add0b0
+0, 34607, 34607, 1152, 418, 0xddd6d0bf
+0, 35759, 35759, 1152, 418, 0x00c7d8aa
+0, 36911, 36911, 1152, 418, 0x915fd36c
+0, 38063, 38063, 1152, 418, 0x28d2d73c
+0, 39215, 39215, 1152, 418, 0xaa7ad8b4
+0, 40367, 40367, 1152, 418, 0xe4e6d680
+0, 41519, 41519, 1152, 418, 0x4084d578
+0, 42671, 42671, 1152, 418, 0x3ab4b6e7
+0, 43823, 43823, 1152, 418, 0x951b66f9, S=1, Skip Samples,
10, 0x0291006e
[FORMAT]
TAG:major_brand=isom
TAG:minor_version=512
-TAG:compatible_brands=isomdby1iso2mp41
+TAG:compatible_brands=isomiso2mp41
TAG:title=Intro
TAG:artist=M83
TAG:album_artist=M83
_______________________________________________
ffmpeg-cvslog mailing list -- [email protected]
To unsubscribe send an email to [email protected]
