Le mer. 21 mai 2025 à 02:53, Michael Niedermayer <mich...@niedermayer.cc> a écrit : > > Hi Romain > > On Tue, May 20, 2025 at 05:45:01PM -0500, Romain Beauxis wrote: > > Le mar. 20 mai 2025 à 16:46, Michael Niedermayer > > <mich...@niedermayer.cc> a écrit : > > > > > > On Mon, May 19, 2025 at 09:46:38AM -0500, Romain Beauxis wrote: > > > > --- > > > > libavcodec/vorbis_parser.h | 11 ++++ > > > > libavcodec/vorbisdec.c | 76 +++++++++++++--------- > > > > libavformat/oggparsevorbis.c | 63 +++++++++++++++++- > > > > tests/ref/fate/ogg-vorbis-chained-meta.txt | 3 - > > > > 4 files changed, 116 insertions(+), 37 deletions(-) > > > > > > breaks fate here (normal x86-64 ubuntu) > > > > > > --- ./tests/ref/fate/ogg-vorbis-chained-meta.txt 2025-05-20 23:42:32.043927021 +0200 > > > +++ tests/data/fate/ogg-vorbis-chained-meta 2025-05-20 23:43:07.908216645 +0200 > > > @@ -7,8 +7,4 @@ > > > Stream ID: 0, frame PTS: 704, metadata: N/A > > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > > Stream ID: 0, new metadata: encoder=Lavc61.19.100 libvorbis:title=Second Stream > > > -Stream ID: 0, frame PTS: 0, metadata: N/A > > > Stream ID: 0, packet PTS: 128, packet DTS: 128 > > > -Stream ID: 0, frame PTS: 128, metadata: N/A > > > -Stream ID: 0, packet PTS: 704, packet DTS: 704 > > > -Stream ID: 0, frame PTS: 704, metadata: N/A > > > Test ogg-vorbis-chained-meta failed. Look at tests/data/fate/ogg-vorbis-chained-meta.err for details. > > > make: *** [tests/Makefile:316: fate-ogg-vorbis-chained-meta] Error 1 > > > > I'm not sure what I'm looking at. Is that the output of running the FATE tests? > > yes > probably was make fate-ogg-vorbis-chained-meta
Woof thanks for catching that indeed. One `return` statement had snuck into my refactorization. About to push a fixed series. > > > > > This diff is already included in the patch: > > > > ``` > > % git show 37370e99451cf0750d5304764ba9031b80e5b3e0 tests/ > > commit 37370e99451cf0750d5304764ba9031b80e5b3e0 (HEAD) > > Author: Romain Beauxis <romain.beau...@gmail.com> > > Date: Sat May 17 12:59:40 2025 -0500 > > > > ogg/vorbis: implement header packet skip in chained ogg bitstreams. > > > > diff --git a/tests/ref/fate/ogg-vorbis-chained-meta.txt > > b/tests/ref/fate/ogg-vorbis-chained-meta.txt > > index b7a97c90e2..1206f86c1f 100644 > > --- a/tests/ref/fate/ogg-vorbis-chained-meta.txt > > +++ b/tests/ref/fate/ogg-vorbis-chained-meta.txt > > @@ -6,10 +6,7 @@ Stream ID: 0, frame PTS: 128, metadata: N/A > > Stream ID: 0, packet PTS: 704, packet DTS: 704 > > Stream ID: 0, frame PTS: 704, metadata: N/A > > Stream ID: 0, packet PTS: 0, packet DTS: 0 > > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, new metadata: encoder=Lavc61.19.100 libvorbis:title=Second Stream > > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > > -Stream ID: 0, packet PTS: 0, packet DTS: 0 > > Stream ID: 0, frame PTS: 0, metadata: N/A > > Stream ID: 0, packet PTS: 128, packet DTS: 128 > > Stream ID: 0, frame PTS: 128, metadata: N/A > > These 2 diffs are not the same > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > You can kill me, but you cannot change the truth. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
