On 2014-07-09 23:09, Derek Buitenhuis wrote:
+        *start = -(mm*60000LL + ss*1000LL + cs*10LL); // just in case negative 
pts

That said, there is still a bug. %d will read negative integers already, you
do not need to check for '-'.

I forgot to mention it in the previous mail.
It is not a bug. Although %d reads negative integers, the seconds and centiseconds are not correctly read. I have tried various ways to read both mm:ss.cs -mm:ss.cs combination, and the one I am using now really works.

I have also tested the demuxer with some samples that I have. Do you think it is necessary to add them into the FATE dataset?

Is it the time to do more regression tests and apply the patch? I am looking forward to having FFmpeg 2.4 in my productivity environment to manipulate LRC files, or am I just too impatient?

Thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to