Re: [FFmpeg-devel] [PATCH 1/5] avutil: add pixelutils API

[Clément Bœsch]

On Sat, Aug 02, 2014 at 08:35:27PM +0200, Michael Niedermayer wrote:
[...]
> > +typedef struct AVPixelUtils {
> > +    /**
> > +     * Sum of absolute differences block functions.
> > +     * src1 and src2 addresses need to be aligned to the block size.
> > +     */
> > +    av_pixelutils_sad_fn sad[AV_PIXEL_BLOCKSZ_NB];
> > +
> > +    /**
> > +     * Sum of absolute differences block functions, (half) unaligned 
> > version.
> > +     * src1 address needs to be aligned to the block size.
> > +     * src2 has no alignment requirement; the 'u' refers to this second 
> > source.
> > +     */
> > +    av_pixelutils_sad_fn sad_u[AV_PIXEL_BLOCKSZ_NB];
> 
> the ABI depends on AV_PIXEL_BLOCKSZ_NB with this design as the arrays
> in the struct depend on its value so no enum values could be added

Right. I simplified the whole API with calling just one function. It
simplifies a lot the usage in filters and it's also ABI stable. New
patchset incoming.

[...]

-- 
Clément B.

pgpLsDXuq2ABN.pgp
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel