On Wed, Aug 06, 2014 at 09:21:18PM +0200, Carl Eugen Hoyos wrote: > On Tuesday 05 August 2014 10:28:38 pm Carl Eugen Hoyos wrote: > > Attached patch copies one line from mp3dec.c into loasdec.c to force > > probing more data and fixes ticket #3821. An alternative is to remove > > the offending line from mp3dec.c (it was added in 2006 or earlier). > > I was unhappy about the patch and iiuc the actual problem is that the > first audio track is initially probed with a score of 25 as h263 and > with a score of 1 as mp3. 1 is not enough (so if I disable the h263 > probe the probe size is increased and loas is correctly detected) but > the 25 are interpreted as the probe value of mp3. > > New patch attached. It stops set_codec_from_probe_data() from > returning probe scores for streams that are not ignored (FFmpeg > doesn't autodetect h263 in mpeg streams) but I suspect it would > still lead to a failure if the audio data is initially detected > as h264 with a score of 25 so a more correct fix is welcome. > > Please review, Carl Eugen
> utils.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > 8d7baf722f3b826ed2fc87e0fa227b3f94ffb2b7 patchprobe.diff > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 6ebbe6c..558a141 100644 should be ok too [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live with honor in this world is to be what we pretend to be. -- Socrates
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
