After further searching and understanding the makefile I see that the lpc code is tested by the complete fate sample suite. This patch is unnecessary.
Anyway to answer the questions... On 2014-08-14 18:14, Christophe Gisquet wrote: > Hi, > > 2014-08-14 18:08 GMT+02:00 James Darnley <james.darn...@gmail.com>: >> Minimum 1, maximum 8. Should I find out what order(s) are actually chosen? > > The encoder algorithm might change and make that information useless, That would mean the test result needs changing too. > but that could be useful. I fear that only checking which orders it > *tests* is insufficient: if the dsp function is broken for some > orders, it may just lead to not selecting those orders and not change > the output. It may be possible that it could be broken in this manner but it sounds, to me, very unlikely. FYI: 1, 4, 6, 7, 8 are all used at least once.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
