Re: [FFmpeg-devel] [FFmpeg-cvslog] doc: document the addition of the AVProbeData.mime_type field and it' s implications

[Andreas Cadhalpun]

On 14.09.2014 00:43, Michael Niedermayer wrote:
note, i will release 2.4 tomorrow (2014-09-14) or rather i intend
to. So anything that isnt pushed to the RELEASE_NOTES by then wont
be in it

OK, so attached are two hopefully uncontroversial patches, one changing 
RELEASE_NOTES to only claim that the API is mostly compatible and the 
other to add Clément's wording to doc/APIChanges.

I still think it would be good to mention the AVProbeData.mime_type 
problem in the RELEASE_NOTES, but if there is a strong preference not to 
do this, then so be it.

Best regards,
Andreas

>From 859003a6ac55243c90a7f1cf8924b8213e53e1df Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
Date: Sun, 14 Sep 2014 00:51:19 +0200
Subject: [PATCH 1/2] doc: don't claim in the RELEASE_NOTES for 2.4 that the
 API didn't change

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
---
 RELEASE_NOTES | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index d30b863..fef0429 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -3,8 +3,8 @@
  └────────────────────────────────────────┘
 
    The FFmpeg Project proudly presents FFmpeg 2.4 "Fresnel", ...
-   FFmpeg 2.4 is API-, but not ABI-compatible with the previous major release.
-   This means that the code using our libraries needs to be rebuilt, but no
+   FFmpeg 2.4 is mostly API-, but not ABI-compatible with the previous major release.
+   This means that the code using our libraries needs to be rebuilt, but only minimal
    source changes should be required.
 
    ┌────────────────────────────┐
-- 
2.1.0

>From e3f28f258fdd395f02e7e67db9a0c0d14dbb8c6e Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
Date: Sun, 14 Sep 2014 00:52:42 +0200
Subject: [PATCH 2/2] doc: mention in APIChanges that AVProbeData must be
 initialized due to the new mime_type field

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
---
 doc/APIchanges | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/APIchanges b/doc/APIchanges
index 90048a5..1a0ba78 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@ -96,7 +96,12 @@ API changes, most recent first:
   Add av_frame_side_data_name()
 
 2014-07-29 - 80a3a66 / 3a19405 - lavf 56.01.100 / 56.01.0 - avformat.h
-  Add mime_type field to AVProbeData.
+  Add mime_type field to AVProbeData, which now MUST be initialized in
+  order to avoid uninitialized reads of the mime_type pointer, likely
+  leading to crashes.
+  Typically, this means you will do 'AVProbeData pd = { 0 };' instead of
+  'AVProbeData pd;'.
+
 
 2014-07-29 - 31e0b5d / 69e7336 - lavu 52.92.100 / 53.19.0 - avstring.h
   Make name matching function from lavf public as av_match_name().
-- 
2.1.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel