Hi, ----- Mail original ----- > Michael Niedermayer <michaelni <at> gmx.at> writes: > > > > > On Fri, Aug 01, 2014 at 01:54:14AM +0200, Michael Niedermayer > > wrote: > > > On Thu, Jul 31, 2014 at 03:40:51PM +0200, Benoit Fouet wrote: > > > > In order not to break a sequence like "SPS IDR SPS IDR", the > boolean > > > > telling that the SPS/PPS has been seen should always be set. > > > > --- > > > > libavcodec/h264_mp4toannexb_bsf.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > LGTM > > > > applied > > > > thanks > > A GitHub user "@thomag" commented on this commit: > > > Consider an mp4 files with just pps in the h264 stream (no sps in > > the > > NAL units, but available from avcc). > > In this case 'ctx->idr_sps_pps_seen' prevents inserting sps in the > > extracted h264, which is then unusable. > > FYI. I cannot confirm if it is correct or not, and what the correct > solution would be. >
I'm willing to try and fix this when/if we have a sample to test that. If there is also an example with just sps in the avcc and only pps in the stream, that'd be perfect... Thanks, -- Ben _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
