Reimar, Sorry for late response. 'HAVE_VSX' is automatically enabled only when HAVE_ALTIVECT is enabled and the CPU is little endian. So if the altivec implementation is broken in little endian, the HAVE_VSX will not be enabled. Thanks.
Rong Yan ------------------ The world has enough for everyone's need, but not enough for everyone's greed. ------------------ 原始邮件 ------------------ 发件人: "Reimar Döffinge";<reimar.doeffin...@gmx.de>; 发送时间: 2014年10月1日(星期三) 凌晨1:51 收件人: "FFmpeg development discussions and patches"<ffmpeg-devel@ffmpeg.org>; 主题: Re: [FFmpeg-devel] patch 1/4: libavcodec/ppc/pixblockdsp.c: fixget_pixels_altivec() and diff_pixels_altivec() for POWER LE On Tue, Sep 30, 2014 at 03:51:55PM +0800, rongyan wrote: > Hi, > I present 4 patches to fix bugs for POWER8 little endian. > I will send 4 patches in 4 different email. This is the first. > The fate test result after merge these 4 patches can be found on > http://fate.ffmpeg.org/ by search "ibmcrl", also attached here to facilitate > the review: > > > > The passed test cases increased from 1649/2169 to 1675/2174. This one seems wrong. I assume HAVE_VSX is a feature related define, which means it should be possible to disable it without breaking anything. If the altivec implementation is broken on little-endian, the correct bug-fix is to disable it. Then as a next step can a different optimized implementation be added. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
