On Wed, Oct 22, 2014 at 09:23:43AM +0800, rongyan wrote: > Michael, > Do you have any suggestion on this patch?
yes, please remove the code duplication (this also applies to already commited code) instead of #if X code a b1(abc) code c #else code a b2(abc) code c #endif you can write #if X #define B b1 #else #define B b2 #endif code a B(abc) code c You can also take a look at our x86 asm, which also generates code for different cpu feature sets, 32 and 64bit from single implementations generally without any duplication of code code duplication makes maintaince harder as bug fixes and updates need to be done to all copies code duplication also makes reading the code harder as its not immedeatly obvious what parts are identical and what differences there are [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User questions about the command line tools should be sent to the ffmpeg-user ML. And questions about how to use libav* should be sent to the libav-user ML.
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list firstname.lastname@example.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel