On Fri, Nov 21, 2014 at 06:03:36AM +1100, Matt Oliver wrote: > On 21 November 2014 02:28, Matt Oliver <protogo...@gmail.com> wrote: > > > On 21 November 2014 01:23, Derek Buitenhuis <derek.buitenh...@gmail.com> > > wrote: > > > >> On 11/20/2014 8:40 AM, Benoit Fouet wrote: > >> > LGTM > >> > >> > >> http://fate.ffmpeg.org/report.cgi?time=20141120142015&slot=i686-windows-icl > >> > >> - Derek > >> > > > > Works fine with lto, but apparently one shouldnt assume the existing code > > is correct for the other cases :P. It appears there was actually an error > > in configure thats been there all along that was never found as it was > > incorrectly detecting icl linker as msvc. Anyway its just missing a couple > > of values that are set for msvc but werent for icl. Im testing a patch now > > so should have fixed it soon. > > > > > OK, all it needed was to disable stripping with icl. Its one of those > things where it took 2 mins to write a patch but then several hours to test > it ;). This has apparently been missing for several years but only became > evident now. So the attached patch should fix everything up.
> configure | 1 + > 1 file changed, 1 insertion(+) > 7cdfa3812263eed574ca3daabff85d8e0d850d12 > 0001-configure-disable-strip-when-using-icl.patch > From d9c7fc366647954f3b554b6e0b8ee5cd7fc09ff3 Mon Sep 17 00:00:00 2001 > From: Matthew Oliver <protogo...@gmail.com> > Date: Fri, 21 Nov 2014 05:55:48 +1100 > Subject: [PATCH] configure: disable strip when using icl. applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
