On Sat, Nov 22, 2014 at 11:59:39AM -0500, compn wrote: > On Sat, 22 Nov 2014 14:17:09 +0100 > Reimar Döffinger <reimar.doeffin...@gmx.de> wrote: > > > On Sun, Sep 07, 2014 at 02:12:34PM +0200, Reimar Döffinger wrote: > > > Also adds a lot of infrastructure necessary for it. > > > Some of it is a bit ugly though. > > > Increases binary size for hardcoded tables by about 12 kB, > > > which is about 15 kB from qdm2_table minus data and code > > > saved that was only used for creating it. > > > > Are there any opinions on this? > > The reason I want to have VLC support for hardcoded tables > > is that it is one of the few big steps to avoid the need > > for global mutable codec state. > > So people who are afraid of our constructs there could just > > switch to hardcoded tables and have much less to worry about. > > i remember lots of complaints about globals before, although i have no > clue if patch good or not. > > done any speed benchmarks on it ?
No, without --hardcoded-tables I don't expect the generated code to change (at least not significantly) and even with that option I expect no speed difference. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
