> Nit: space after commas.
> Is it necessary to typedef the structure on top of declaring it? In C, this:
> {...} is legal, no need to typedef it.> Apart from that, I think the helper structure should be scoped in the > ff_namespace > Nit: no empty line between doxy and declaration. Patch attached.
0001-Squashed-commits.patch
Description: Binary data
> And I wonder: does Doxygen understand the resulting construct?
I guess that (not good) behaviour is not changed.
BTW, isn't the whole stuff slightly over-engineered? Why is "binary
compatibility" needed (and with what?).
Wouldn't it be easier in terms of compatibility, readability and doxygenability
to define simple C structure?
struct AVBPrint {
char *str; /**< string so far */
unsigned len; /**< length so far */
unsigned size; /**< allocated memory */
unsigned size_max; /**< maximum allocated memory */
char reserved_internal_buffer[1024];
};
Vadim Kalinsky
kalinsky.ru
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
