On Monday, 09 February 2015 at 10:42, Gupta, Maneesh wrote: > > -----Original Message----- > > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel- > > boun...@ffmpeg.org] On Behalf Of wm4 > > Sent: Friday, February 06, 2015 4:58 PM > > To: ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to libavutil > > > > On Fri, 6 Feb 2015 11:06:28 +0000 > > "Gupta, Maneesh" <maneesh.gu...@amd.com> wrote: > > > > > > > -----Original Message----- > > > > From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel- > > > > boun...@ffmpeg.org] On Behalf Of wm4 > > > > Sent: Friday, February 06, 2015 4:31 PM > > > > To: ffmpeg-devel@ffmpeg.org > > > > Subject: Re: [FFmpeg-devel] [PATCH 1/3] Add clew.c & clew.h to > > > > libavutil > > > > > > > > On Fri, 6 Feb 2015 11:14:21 +0100 > > > > Hendrik Leppkes <h.lepp...@gmail.com> wrote: [...] > > > > > > > > > > Using such a library is fine, if its deemed the best solution > > > > > available, but flat-out importing its code into avutil is not. > > > > > > > > +1 > > > > > > > > Also look at all these awful "portability" hacks in the added code. > > > > It's not a good idea to agree to maintaining this terrible mess. > > > > > > Alright. Can you suggest an alternate way of building ffmpeg using clew? > > Clew has lot of advantages and essentially consists of a single source and > > header file. I will modify and resubmit the patch accordingly. > > > > Convince upstream to package it as real library. > > Clew can already be built as a static library. It ships with a cmake > file. However I am a little confused here. My intention for using clew > was to remove the pain of having to specify multiple parameters to > enable the OpenCL feature. If clew is used as a library, instead of > having use --extra-cflags, --extra-ldflags to specific the path to > standard OpenCL bits I would have to still use them to point ffmpeg > to the path to clew. Or am I missing something here?
FWIW I didn't have to pass ANY --extra-cflags and --extra-ldflags to build FFmpeg with OpenCL on Fedora 21. I only had to install opencl-headers and ocl-icd-devel packages. Also, I still haven't seen you respond to my question about the library itself. It's not packaged for any major distro and I'm still not sure who is its upstream. I found a GoogleCode project and a SourceForge project, both by different authors (one seems to be independent, the other is the author of clcc, from which clew seems to be derived from). I'm not sure using a library with uncertain status is such a good idea. Regards, Dominik -- MPlayer http://mplayerhq.hu | RPM Fusion http://rpmfusion.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
