On Mon, 9 Feb 2015 22:36:45 +0000 (UTC) Carl Eugen Hoyos <ceho...@ag.or.at> wrote:
> wm4 <nfxjfg <at> googlemail.com> writes: > > > Fate still passes. > > I am not sure transparency is tested by fate. > Did you test with a pal8 image with transparency? Do you have one at hand? > > - ((pixdesc)->nb_components == 2 || (pixdesc)->nb_components == 4 > > || (pixdesc)->flags & AV_PIX_FMT_FLAG_PAL) > > + ((pixdesc)->nb_components == 2 || (pixdesc)->nb_components == 4) > > I am not saying this isn't correct (I don't > know) but isn't this hunk completely > unrelated to the rest of the patch? Erm, now that you point it out... yes, it's wrong in this form. The macro should probably be replaced with a check for the alpha flag. I'll double-check tomorrow. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel