On Tue, Feb 17, 2015 at 11:58:06AM +0000, Kevin Wheatley wrote: > Oops, I missed that when I allowed the atom to be added to the end of > the extradata, updated. > > I'm not sure if logging as an error is appropriate in the case when > the extradata is not large enough, for this to occur the file will > have been truncated somehow and the mov_read_extradata function will > have logged a warning and returned 0. Which at first glance seams > wrong - should mov_read_extradata return something other than 0 in > this case? > > Either way it does mean the code could read the wrong value, but > should not crash with the guard in place.
if the codec id doesnt match the expected, mov_read_extradata will return 0 even without any truncation. In this case the error message would be incorrect [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
