L'octidi 8 ventôse, an CCXXIII, Andreas Cadhalpun a écrit : > the bit format muxer currently segfaults, when it is passed a packet of size > 0. > This can be triggered e.g. with: > ffmpeg -y -f lavfi -i sine=duration=0.1 -c:a flac -f bit /dev/null > > Attached patch fixes this.
This looks wrong. The "bit" muxer seems to assume packets have a constant
size, apparently 10 octets. Someone knowing the format should check, but I
suppose this would be more correct:
if (pkt->size != 10)
return AVERROR(EINVAL);
Also, it seems you should not be able to mux FLAC into this format, the
write header callback does not validate enough. It looks like this muxer is
a quick-and-dirty implementation, emphasis on the dirty.
Last: how come ffmpeg/lavf tries to mux an empty packet?
Regards,
--
Nicolas George
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
