Hi,

the asserts in av_rescale_rnd are unnecessary since commit 3929c174.

Best regards,
Andreas
>From 932813ac54beaca4c1e02d76b76c50097d0f1336 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
Date: Sat, 28 Feb 2015 19:45:31 +0100
Subject: [PATCH] avutil/mathematics: remove superfluous asserts from
 av_rescale_rnd

The function returns INT64_MIN in these cases and it is called with
potentially negative values e.g. from av_image_check_sar.

Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com>
---
 libavutil/mathematics.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavutil/mathematics.c b/libavutil/mathematics.c
index 126cffc..9512d86 100644
--- a/libavutil/mathematics.c
+++ b/libavutil/mathematics.c
@@ -63,9 +63,6 @@ int64_t av_gcd(int64_t a, int64_t b)
 int64_t av_rescale_rnd(int64_t a, int64_t b, int64_t c, enum AVRounding rnd)
 {
     int64_t r = 0;
-    av_assert2(c > 0);
-    av_assert2(b >=0);
-    av_assert2((unsigned)(rnd&~AV_ROUND_PASS_MINMAX)<=5 && (rnd&~AV_ROUND_PASS_MINMAX)!=4);
 
     if (c <= 0 || b < 0 || !((unsigned)(rnd&~AV_ROUND_PASS_MINMAX)<=5 && (rnd&~AV_ROUND_PASS_MINMAX)!=4))
         return INT64_MIN;
-- 
2.1.4

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to