On Thu, Mar 5, 2015, at 06:36 PM, Derek Buitenhuis wrote:
> Configure your name and email.
Done.

> This doesn't look like it was sent with git send-email?
I was not. I've used git format-patch but I'll setup git send-email.

> URLs in commit messages tend not to be useful later on.
How should I send test-urls?

> Should be on same line.
> else and { on the same line.
I've used the same coding style as it was before my patch. Mixing it in
the same function would look weird.


So should I post and completely new patch with the improvements or how
should this be done?
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to