On Sat, 18 Apr 2020, Michael Niedermayer wrote:
On Sat, Apr 18, 2020 at 07:03:16PM +0200, Marton Balint wrote:
On Sat, 18 Apr 2020, Michael Niedermayer wrote:
On Sat, Apr 18, 2020 at 12:14:12PM +0200, Anton Khirnov wrote:
[...]
diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 3d0d4969b8..cb7ce7a158 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -535,7 +535,7 @@ FATE_FILTER_PP = fate-filter-pp fate-filter-pp1
fate-filter-pp2 fate-filter-pp3
FATE_FILTER_VSYNTH-$(CONFIG_PP_FILTER) += $(FATE_FILTER_PP)
$(FATE_FILTER_PP): fate-vsynth1-mpeg4-qprd
-fate-filter-pp: CMD = framecrc -flags bitexact -idct simple -i
$(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags +bitexact -vf
"pp=be/hb/vb/tn/l5/al"
+fate-filter-pp: CMD = framecrc -flags bitexact -export_side_data venc_params -idct
simple -i $(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags
+bitexact -vf "pp=be/hb/vb/tn/l5/al"
ffmpeg / ffplay should automatically enable the exportation of the parameters
when theres a filter downstream that needs such parameters
Otherwise the use of these filters (and other filters that need any kind of
information thats unavailable by default) would become a bit akward to use
Why? It is not unusual at all that you need to specify certain extra
parameters to export some kind of metadata.
in addition to what carl said.
It seems you consider that "normal", i wouldnt really consider it normal
to have to specify this by hand.
All the information is there for the code to do this automatically and its
not really a A vs B alternative. Instead "-export_side_data venc_params"
with a filter using this afterwards is the only functional choice
And how will you decide if a pp filter in a complex filtergraph is
actually processing your video input or not? Or how will you know that the
pp filter is parametrized in a way that it wants to use motion vectors?
This not looks to me easy at all. Automagically enabling this would look a
lot more like a heuristic to me, a case when the application wants to be
smarter than it actually is.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
