On Tue, Apr 21, 2020 at 01:08:05PM +0200, Nicolas George wrote: > Limin Wang (12020-04-21): > > OK, below is the commit log, please help to review whether it's your > > expected log: > > > > NOTE about the testing effect: > > subtitle packet will be marked as keyframe, it'll change below testing > > reference > > files: > > tests/ref/fate/binsub-movtextenc and tests/ref/fate/sub2video > > > > audio packet will be marked as keyframe, it'll change below testing > > reference file > > tests/ref/fate/movenc > > You are writing in the future tense, meaning you are making a > prediction. > > You need to explain what you did, and the results. For example, did you > re-run the tests with -w, as suggested in > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260837.html > to examine the files before and after the change?
I have checked with one of non-empty-moov.mp4, and have observed one byte difference only(02 and 01). I haven't tool to dump every box in detail. If you think it's necessary, I can looked at the movenc muxer further and figure out which field it's. [lmwang@vpn ffmpeg]$ hexdump -C non-empty-moov.mp4 > non-empty-moov.hex [lmwang@vpn ffmpeg]$ hexdump -C non-empty-moov1.mp4 > non-empty-moov1.hex [lmwang@vpn ffmpeg]$ diff non-empty-moov.hex non-empty-moov1.hex 162c162 < 00000a10 08 02 00 00 00 00 00 00 14 74 66 64 74 01 00 00 |.........tfdt...| --- > 00000a10 08 01 01 00 00 00 00 00 14 74 66 64 74 01 00 00 |.........tfdt...| > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". -- Thanks, Limin Wang _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".