On Fri, May 29, 2020 at 02:20:37PM -0300, James Almer wrote:
> current_picture was not writable here because a reference existed in
> at least avctx->coded_frame, and potentially elsewhere if the caller
> created new ones from it.

Please elaborate when and how the encoder internal buffer becomes
read only
i simply took your code and replaced

-        ret = av_frame_make_writable(s->current_picture);
-        if (ret < 0)
-            return ret;
+        ret = av_frame_is_writable(s->current_picture);
+        if (ret <= 0)
+            return -1;

and fate is fully happy which tests both the encoder and the filters
using it
also if this is for coded_frame then shouldnt it be under FF_API_CODED_FRAME?
iam clearly missing something here

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to