On Fri, 29 May 2020 23:41:46 +0200
"Michael Niedermayer" <mich...@niedermayer.cc> wrote:

> 
> On Fri, May 29, 2020 at 10:54:59AM +0000, Zane van Iperen wrote:
> > Signed-off-by: Zane van Iperen <z...@zanevaniperen.com>
> > ---
> >  Changelog                |  1 +
> >  libavformat/Makefile     |  1 +
> >  libavformat/allformats.c |  1 +
> >  libavformat/kvag.c       | 82
> > +++++++++++++++++++++++++++++++++++++++- libavformat/version.h    |
> >  2 +- 5 files changed, 85 insertions(+), 2 deletions(-)
> 
> should the muxer not be in its own file ?
> that would avoid #if*
> 
Normally, I'd agree. However, it's a very simple format and there's not
actually that much code, so I think separate files is overkill for this.

Zane

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to