On Mon, 6 Jul 2020 18:29:57 +0200 "Michael Niedermayer" <mich...@niedermayer.cc> wrote:
> On Mon, Jul 06, 2020 at 09:24:20AM +0000, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen <z...@zanevaniperen.com> > > --- > > libavformat/Makefile | 2 +- > > libavformat/apm.c | 62 > > ++++++++++++++++++++++++-------------------- 2 files changed, 35 > > insertions(+), 29 deletions(-) > > I think the commit message should be more elaborate > "avformat/apm: use new extradata format" > doesnt really say what changes, why its changes > What's a nice way of saying "I made an error in the old format and had to change it in order to keep things simple in the muxer."? Essentially, I - Handle the dodgy WAVEFORMATEX (that I missed before) correctly, and - Pass through the entire APMState structure to the decoder instead of only some fields. > You also may want to add yourself to the MAINTAINERs file > Will do, I'll send it in a different patchset. Would this warrant commit access? Because I'm including a GPG key, I'd like to have the commit signed, and `git format-patch` doesn't like signatures. Zane _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
