On 2020-08-22 12:59 +0200, Nicolas George wrote:
> Alexander Strasser (12020-08-15):
> > If I'm not mistaken that reason for the rewrite didn't make
> > it into the commit message:
>
> You are right. The reason for the complete rewrite was that the original
> code was completely broken which I did not want to include permanently
> in the history.
>
> By completely broken, I mean it used redundant string searches without
> bothering about delimiters and syntax. That mean some parts would
> parse "/redirect?url=http://example.com/"; with everything until "://"
> considered the protocol.
OK, I see.
Thanks for the confirmation.
For the record I think such reasons ("Why?") should always be
included in the commit message.
E.g. just phrase it in an objective neutral way, avoiding
assesments like "completely broken".
Alexander
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
