On 9/1/20, Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > It should be a 64-bit integer, otherwise it overflows and fails > on files greater than 2GB on some systems like x86_64 Linux. > > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index dcec74662d..f0b4edc2ed 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5095,7 +5095,7 @@ static int mov_read_sidx(MOVContext *c, AVIOContext > *pb, MOVAtom atom) > // See if the remaining bytes are just an mfra which we can ignore. > is_complete = offset == stream_size; > if (!is_complete) { > - int ret; > + int64_t ret; > int64_t original_pos = avio_tell(pb); > int32_t mfra_size; > if ((ret = avio_seek(pb, stream_size - 4, SEEK_SET)) < 0) > -- > 2.28.0 >
Of course LGTM. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".