On Wed, Sep 09, 2020 at 04:58:35PM +0200, Nicolas George wrote: > The link API provides an abstraction, where a filter sees on an > input a stream of frames or samples terminated by a status change. > Calling ff_outlink functions on an input bypasses this abstraction > to peek inside implementation details; it may work now, but it can > break at any point if the implementation is changed or if new > conditions are triggered. > > I do not know how to fix these filters, but adding these comments > will avoid new code to imitate the pattern and require fixing too. > > Signed-off-by: Nicolas George <geo...@nsup.org> > --- > libavfilter/af_afade.c | 2 ++ > libavfilter/af_afir.c | 3 +++ > libavfilter/af_headphone.c | 1 + > libavfilter/f_interleave.c | 3 +++ > libavfilter/vf_framepack.c | 2 ++ > libavfilter/vf_xfade.c | 2 ++ > libavfilter/vf_xfade_opencl.c | 2 ++ > 7 files changed, 15 insertions(+) >
Patch rejected. There is no need to fix what is not broken. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
