On 28/09/2020 02:17, Pavel Koshevoy wrote:
On Wed, Sep 23, 2020 at 1:32 PM Paul B Mahol <one...@gmail.com> wrote:

On Mon, Sep 21, 2020 at 09:47:40PM -0600, Pavel Koshevoy wrote:
Allow setparams to be used with hw backed frames and
avoid an assertion failure in avfilter_config_links.
---
  libavfilter/vf_setparams.c | 3 +++
  1 file changed, 3 insertions(+)


LGTM




applied, pushed.

I reverted this: setparams is not hwframe aware so adding the flag does not 
make sense.  It broke all attempts to use it with hardware frames, because the 
default context passthrough is required.

E.g.

$ ./ffmpeg_g -y -i in.mp4 -init_hw_device vaapi:/dev/dri/renderD128 -an -vf 
hwupload,setparams=range=full,hwdownload out.mp4
...
[hwdownload @ 0x55916d90a580] The input must have a hardware frame reference.
[Parsed_hwdownload_2 @ 0x55916dcab140] Failed to configure input pad on 
Parsed_hwdownload_2
Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while processing the decoded data for stream #0:0
Conversion failed!


Perhaps it would help if you explained what your original problem was, because 
it definitely wasn't this.

- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to