On Wed, Dec 23, 2020 at 11:29 PM Nicolas George <geo...@nsup.org> wrote:
> Marton Balint (12020-12-23): > > > +static int librist_get_file_handle(URLContext *h) > > > +{ > > > + RISTContext *s = h->priv_data; > > > + > > > + return s->fd; > > > +} > > > > I don't think this is right, s->fd is a flow id, not an ordinary file > > descriptor. You probably don't need this callback anyway. > > It is indeed not a file descriptor at all, returning it like that would > cause very serious bugs. > > I nowhere see proof that this cause any bugs. > It seems this library does not make its file descriptors at all. It > means it cannot be used by FFmpeg in non-blocking mode, nor by any > application with a standard Unix event loop This is fortunately completely false statement. It works just fine. . > > Regards, > > -- > Nicolas George > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".