> Hi Anton, Haihao > If this is the case, we allocated the string in caller, free and reallocate > it in callee. > It's not a good practice. > 1. It will make the user confused, The original qsvdec_other.c author and I > are both confused about this. > https://github.com/FFmpeg/FFmpeg/blob/399c1f923574234e899beef72fe249863bd1722a/libavcodec/qsvdec_other.c#L86 > 2. The av_opt_free may change the design in the future, the new design may > not use av_freep to free the string > > Is it possible use av_opt_set(s, "load_plugin", uid, 0) in qsv_decode_init?
The type of option 'load_plugin' is AV_OPT_TYPE_INT. Did you mean 'load_plugins' ? I agree with you that it would be better to use 'av_opt_set(s, "load_plugins", uid, 0)' to set the value for option 'load_plugins'. Thanks Haihao > thanks > > > > On Fri, Jan 29, 2021 at 8:37 AM Xiang, Haihao <haihao.xi...@intel.com> > wrote: > > > On Wed, 2021-01-27 at 13:44 +0100, Anton Khirnov wrote: > > > Quoting Xu Guangxin (2021-01-05 03:43:37) > > > > --- > > > > libavcodec/qsvdec_h2645.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c > > > > index 02c41883b6..3d6e85230f 100644 > > > > --- a/libavcodec/qsvdec_h2645.c > > > > +++ b/libavcodec/qsvdec_h2645.c > > > > @@ -69,6 +69,8 @@ static av_cold int qsv_decode_close(AVCodecContext > > > > *avctx) > > > > { > > > > QSVH2645Context *s = avctx->priv_data; > > > > > > > > + av_freep(&s->qsv.load_plugins); > > > > > > Does this not get freed by av_opt_free()? > > > > > > > Yes, it gets freed by av_opt_free() when closing the AVCodecContext, we may > > remove the above code from qsvdec. > > > > Thanks > > Haihao > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".